Fix PHP 8.4 deprecation notices #1459
Conversation
|
Maybe we should update styleci.yml and automate the fixes |
|
@Hlavtox is there something blocking you from upgrading to 9? |
|
in preset: psr12
risky: true
enabled:
- blank_line_before_return
- fully_qualified_strict_types
- hash_to_slash_comment
- include
- method_separation
- native_function_casing
- no_blank_lines_between_uses
- no_duplicate_semicolons
- no_multiline_whitespace_before_semicolons
- no_php4_constructor
- no_short_bool_cast
- no_singleline_whitespace_before_semicolons
- no_trailing_comma_in_singleline_array
- no_unused_imports
- no_whitespace_before_comma_in_array
+ - nullable_type_declarations
- ordered_imports
- phpdoc_align
- phpdoc_indent
- phpdoc_inline_tag
- phpdoc_no_access
- phpdoc_no_simplified_null_return
- phpdoc_property
- phpdoc_scalar
- phpdoc_separation
- phpdoc_to_comment
- phpdoc_trim
- phpdoc_type_to_var
- phpdoc_types
- phpdoc_var_without_name
- print_to_echo
- short_array_syntax
- single_quote
- spaces_cast
- standardize_not_equal
- trailing_comma_in_multiline_array
- trim_array_spaces
- whitespace_after_comma_in_array |
|
Hi @Sephster we have a dependency on your repository at https://github.com/PrestaShop/PrestaShop that is what motivated this contribution. Just to anticipate the timing, do you think the next patch that includes this compatibility will be released soon or will we have to wait a few weeks or more? |
|
Hi @Sephster, I added the config to the linter. :-) Yes, as @jolelievre said, we wanted to avoid as many major updates as we can. Get it working, stabilized, then get on the major updates if we have time. |
|
Yep, anyway it may still be useful for other projects |
|
Happy to merge this but currently failing because of dependencies. Are you able to fix this? If not, I'll see if I can get some time later today. Thank you and thanks for letting me know about PrestaShop. Always nice to hear about down stream systems! Looks a great product |
Is it possible to do a patch release on 8.x branch after merge? :-) Thanks!